Closed tomwilkie closed 7 years ago
I did not face this problem yet but any reason it can be only from client code? Server modifies the metadata as well.
This happens when a gRPC instrumented server triggers two gRPC calls as the result of a single incoming RPC. So I don't think it will happen in the server.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
I guess the two gRPC calls should be goroutines that share the same context?
They are - see here: https://github.com/weaveworks/cortex/blob/master/distributor/distributor.go#L321
@tomwilkie thank you for the fix. LGTM.
Fixes #12