grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Standardize error classes and automatically add span tags #27

Closed danielamiao closed 7 years ago

bhs commented 7 years ago

(discussed offline... waiting for a unittest of the function that has the interesting logic in it)

bhs commented 7 years ago

@danielamiao LGTM, but there are conflicts to resolve. :-/

danielamiao commented 7 years ago

All resolved! :)

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


danielamiao commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!