grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Add gRPC-OpenTracing interceptors for Go #3

Closed bhs closed 8 years ago

bhs commented 8 years ago

See the README.md for usage examples, etc.

This is possible thanks to https://github.com/grpc/grpc-go/pull/867.

bhs commented 8 years ago

cc: @dominikh per our conversation on Gitter about this

I would like to include more information about the peer (via tags/etc), but unfortunately I'm not sure where to access that given what's (not) exported in gRPC.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


bhs commented 8 years ago

Per the google CLA thing: "I did it"

googlebot commented 8 years ago

CLAs look good, thanks!

bg451 commented 8 years ago

Everything looks good to me, although I would recommend adding an Option that allows users to specify a set of tags that'll be applied whenever a new span is created in the interceptor.

jmacd commented 8 years ago

👍

bhs commented 8 years ago

Comments addressed... merging.