search

grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Added C# support #42

Closed Falco20019 closed 6 years ago

Falco20019 commented 6 years ago

I implemented it based on Grpc v1.11.0 and OpenTracing v0.11.0. Just as preview and for feedback for now, please do not yet merge. I wait for https://github.com/opentracing/opentracing-csharp/pull/72 to be merged to do some adjustments. I also want to add some tests.

Falco20019 commented 6 years ago

Hi @cwe1ss, nice to also see you on this project :) Thanks for the feedback! I incorporated it in the first commit. The second commit is just renaming and applying the correct folder structure to the new namespaces. I kept it seperate to make the changes better comparable in the diff.

tedsuo commented 6 years ago

Thanks @Falco20019! This looks like a great start.

FYI, we are actually freezing this repo in favor of separate repos in opentracing-contrib, where we can keep track of Issues/PRs better, and allow each grpc plugin to have it's own version number.

I've created a repo here, and made you and the C# maintainers admins: https://github.com/opentracing-contrib/csharp-grpc

If you could modify your PR to be a stand-alone repo, with the initial semver version v0.1.0, that would be great!

Falco20019 commented 6 years ago

I just reworked it into a stand-alone repository and also made some adjustments to make the API closer to the java version. There are still some open points to resolve for which I will create issues in the other repo.