grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Fix NPE in Client filter #45

Closed alexnederlof closed 2 years ago

alexnederlof commented 6 years ago

Servers can return status codes without a description. In that case, it returns null which causes an NPE in the ImmutableMap implementation. This only adds the description if set, and otherwise just logs the error code.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
alexnederlof commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!