grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Don't flag errors in class "Success" #46

Closed bboreham closed 6 years ago

bboreham commented 6 years ago

E.g. if the operation was cancelled, that's not an error.

Fixes #44

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
googlebot commented 6 years ago

CLAs look good, thanks!

bboreham commented 6 years ago

Re-opened at https://github.com/opentracing-contrib/go-grpc/pull/1 , where this repo seems to have silently moved.

bboreham commented 6 years ago

Replaced by https://github.com/opentracing-contrib/go-grpc/pull/1