grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Add ctx in SpanDecorator option #47

Open mmoustai opened 5 years ago

mmoustai commented 5 years ago

I needed to add specific tag from contextKey set in the context on an other middleware before this one.

I wasn't able to access it without adding the context in the decorator.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
mmoustai commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

fho commented 5 years ago

@rnburn could this be merged?