grpc-ecosystem / grpc-opentracing

OpenTracing is a set of consistent, expressive, vendor-neutral APIs for distributed tracing and context propagation
BSD 3-Clause "New" or "Revised" License
472 stars 98 forks source link

Update deprecated LogEventWithPayload calls to LogFields instead #9

Closed rlhh closed 7 years ago

rlhh commented 7 years ago

Reason LogEvent together with it's sister functions have been deprecated in OpenTracing.

Error logging that is done through these deprecated functions might not be correctly 'translated' to the new LogRecord struct as it will require individual tracer implementations doing extra checks for an accurate translation.

bhs commented 7 years ago

LGTM, thanks!