search

grpc-ecosystem / grpc-simon-says

Multiplayer Simon Says game using bidirectional gRPC streaming
Apache License 2.0
133 stars 34 forks source link

Kubernetes ReplicationController vs Deployment #4

Closed panzerdev closed 7 years ago

panzerdev commented 8 years ago

I wonder why you use a ReplicationController instead of a Deployment for the Pod? I thought the RC is deprecated and the Deployment is now the right thing to do.

markmandel commented 8 years ago

I have the code to update this - I should also do a PR for it.

thesandlord commented 8 years ago

@markmandel any update on this? Should be a very straightforward change, I can do it if you want.

markmandel commented 8 years ago

I've got this tied up with the upgrade to gRPC 1.0 - which I have some infrastructure work I want to complete on gRPC before wrapping it all in together. So it's coming, I just haven't got there yet.

markmandel commented 7 years ago

This has now been merged, so I'm closing this ticket.