Closed meteatamel closed 8 years ago
A couple of minor comment tweaks, but otherwise, LGTM. Good to merge one the comments are fixed.
The comments are useful for the workshop...We have the same in node.js client.
Actually.. let me come back on that again. If this is a completed implementation, why should the comments be there? People don't know this is specifically for a workshop.
My next nit picky issue, is that the Javadocs are inconsistently applied.
This is particularly true in ConsoleInputReader (and when reading the code, it took me a while to work out what the functions where doing) - let's add Javadocs to everything
LGTM!
LGTM, @markmandel can you take a look and merge?