search

grpc-ecosystem / grpc-simon-says

Multiplayer Simon Says game using bidirectional gRPC streaming
Apache License 2.0
132 stars 33 forks source link

Added Java command line client #5

Closed meteatamel closed 8 years ago

thesandlord commented 8 years ago

LGTM, @markmandel can you take a look and merge?

markmandel commented 8 years ago

A couple of minor comment tweaks, but otherwise, LGTM. Good to merge one the comments are fixed.

meteatamel commented 8 years ago

The comments are useful for the workshop...We have the same in node.js client.

markmandel commented 8 years ago

Actually.. let me come back on that again. If this is a completed implementation, why should the comments be there? People don't know this is specifically for a workshop.

markmandel commented 8 years ago

My next nit picky issue, is that the Javadocs are inconsistently applied.

This is particularly true in ConsoleInputReader (and when reading the code, it took me a while to work out what the functions where doing) - let's add Javadocs to everything

markmandel commented 8 years ago

LGTM!