search

grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.
https://grpc-ecosystem.github.io/grpc-spring/
Apache License 2.0
3.46k stars 811 forks source link

feat: Add gRPC Metrics #1010

Closed DNVindhya closed 7 months ago

ST-DDT commented 8 months ago

AFAICT these metrics are not specifically spring related, so they could be used by other bindings as well. I think we could add it to the OpenTelemetry bindings repo directly that way other libraries would benefit from it as well and we don't risk having a different implementation from the rest. We could still have the required autoconfiguration for the metrics in this library.

Or are there some already here: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/grpc-1.6/library ?

fengli79 commented 8 months ago

@ST-DDT We are trying to implement the gRPC A66 metrics spec, with micrometer. We won't introduce any OTel dependency at this moment, and the instrumentation + exporting are fully implemented in micrometer. And later on, based on the micrometer instrumentation, OpenTelemetry may provide an end to end user experience in a non-invasive way, such as using a shim, etc.

I see you are the contributor of the gRPC metrics in micrometer as well, could you help to review and maybe accelerate the approval process there (we can implement in micrometer directly)?

ST-DDT commented 8 months ago

We are trying to implement the gRPC A66 metrics spec, with micrometer. We won't introduce any OTel dependency at this moment, and the instrumentation + exporting are fully implemented in micrometer.

Oh, I for some reason I have mistaken this for OT.

I see you are the contributor of the gRPC metrics in micrometer as well, could you help to review and maybe accelerate the approval process there (we can implement in micrometer directly)?

Sure. Just ping me there and I'll have a look.

DNVindhya commented 7 months ago

Closing this draft PR, as the changes have been merged in #1021.