search

grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.
https://grpc-ecosystem.github.io/grpc-spring/
Apache License 2.0
3.43k stars 809 forks source link

Remove the `attempt` base unit for grpc_client_attempt_started metric #1041

Closed fengli79 closed 5 months ago

fengli79 commented 5 months ago

Remove the attempt base unit for grpc_client_attempt_started metric, to make sure the generated metrics name in the Prometheus is actually grpc_client_attempt_started_total instead of grpc_client_attempt_started_attempt_total and gets aligned with other languages (C++ for example).

fengli79 commented 5 months ago

What about the server call metrics? Wouldnt they have the same issue?

Yes, it has the same issue, I'm removing it.