search

grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.
https://grpc-ecosystem.github.io/grpc-spring/
Apache License 2.0
3.43k stars 809 forks source link

feat: apply grpc service config from consul (#1045) #1046

Closed onyn closed 3 months ago

onyn commented 5 months ago

Closes #1045

ST-DDT commented 4 months ago

Please resolve the merge conflicts.

onyn commented 4 months ago

Done. Two questions remains:

  1. Should we support canarying changes feature of DNS resolver? This may be supported in the future, using separate metadata key in case of demand.
  2. Currently GRPC doesn't expose methods for parsing json string into ConfigOrError object. Shoud we wait for it?
ST-DDT commented 4 months ago

Thanks for your fast response.

Lets wait a bit on how upstream decides on the API topic.

onyn commented 3 months ago

That was expected.

So, just one question left:

  1. Should we support canarying changes feature of DNS resolver? This may be supported in the future, using separate metadata key in case of demand.
  2. Currently GRPC doesn't expose methods for parsing json string into ConfigOrError object. Shoud we wait for it?
ST-DDT commented 3 months ago
  1. Should we support canarying changes feature of DNS resolver?

No, just keep it simple. If grpc adds an official API, we can adopt it then.

onyn commented 3 months ago

Rebased and squashed.

onyn commented 3 months ago

Rebased & squashed.