search

grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.
https://grpc-ecosystem.github.io/grpc-spring/
Apache License 2.0
3.43k stars 809 forks source link

Add support for maxInboundMetadataSize client configuration #1064

Closed o-shevchenko closed 4 months ago

o-shevchenko commented 4 months ago

Add support for maxInboundMetadataSize client configuration. If metadata (for example an exception message) exceeds the limit we may receive a client error:

io.grpc.StatusRuntimeException: INTERNAL: RST_STREAM closed stream. HTTP/2 error code: PROTOCOL_ERROR

See: https://grpc.github.io/grpc-java/javadoc/io/grpc/ManagedChannelBuilder.html#maxInboundMetadataSize(int) See: https://github.com/LogNet/grpc-spring-boot-starter/blob/master/grpc-spring-boot-starter/src/main/java/org/lognet/springboot/grpc/autoconfigure/GRpcServerProperties.java#L128

o-shevchenko commented 4 months ago

@ST-DDT Thanks for the review! What is the process of merging this PR? When we should expect next release with these changes? Thanks!

ST-DDT commented 4 months ago

What is the process of merging this PR?

I have some free time next week to look into that.

o-shevchenko commented 4 months ago

It will also be great to merge changes for retries config: #574. The lack of available configs is really a blocker in using this lib