grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.
https://grpc-ecosystem.github.io/grpc-spring/
Apache License 2.0
3.41k stars 808 forks source link

[Docs] gRPC-Spring-Boot-Starter Documentation: Getting Started - Project Setup (Server and Client) Exhibitory Imagery #1077

Closed arnoldmashava closed 2 months ago

arnoldmashava commented 3 months ago

¿Where is the exhibitory imagery pertaining to the Project Setup for the grpc-spring-server and Project Setup for the grpc-spring-client components in the Ver. 3.x Release iteration of the Documentation?

I was initially tempted to submit a Pull Request but that would have been a untidy Dirty-Dance, which without an admissible and valid source URL from which this imagery would be embedded, would translate to completely removing the intended visualizations on how the gRPC-Spring-Boot-Starter project should be setup.

Respectively, for the grpc-spring-server and grpc-spring-client components, the intended Documentation visualizations point to the following invalid sources:

  1. https://grpc-ecosystem.github.io/grpc-spring-boot-starter/assets/images/server-project-setup.svg

  2. https://grpc-ecosystem.github.io/grpc-spring-boot-starter/assets/images/client-project-setup.svg

Muchas Gracias.

ST-DDT commented 3 months ago

The correct links are:

ST-DDT commented 3 months ago

Thanks for bringing this to our attention and your quick fix.

arnoldmashava commented 3 months ago

Thanks for bringing this to our attention and your quick fix.

It is such immense honor @ST-DDT - albeit the seemingly infinitesimal gravitas of my Dirty-Dancing moves, in the form of single-line and minor git commits.

The anticipation for my Wandering Eye is that of enhanced visual stimulus emanating from refined gRPC-Spring-Boot-Starter Documentation aesthetics - for the rendered outputs of both the English and 中文 *.md sets of source files into which the proposed amendments were petrissaged.

Herewith some Orange haze and Protobuf levitation:

>_ sudo ¡Muchas Gracias! --verbose