search

grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.
https://grpc-ecosystem.github.io/grpc-spring/
Apache License 2.0
3.49k stars 819 forks source link

Actuator healthcheck #1103

Open charlesmst opened 5 months ago

charlesmst commented 5 months ago

This is the initial work for #1091.

It is only implementing the check now, but watch will be added later by pushing metrics every 30s as @ST-DDT suggested.

I was wondering if this should be the default behavior when the actuator is present, so I added a property to enable this instead of the GRPC standard health endpoint.

charlesmst commented 4 months ago

Hi @ST-DDT, thanks for the review. I think all your comments have been addressed. Let me know if you see more improvements for this feature. About the watch method, I didn't start it yet, but I was thinking in doing it in a separate PR because I think it will involve a lot more code, or do you prefer to have everything here in this pr?

charlesmst commented 3 months ago

Hey @ST-DDT , thanks for your review. What is the process to merge this PR? If I need more reviews, please tell me who or where I can request them.

ST-DDT commented 3 months ago

What is the process to merge this PR?

Sorry for the delay. The maintainers have to review/merge it.

javiertoja commented 1 month ago

Hello @ST-DDT do you know if this pr is blocked for some reason or can I contact some maintainers to help with it, I'm facing a similar situation and having this in the main branch will be good

ST-DDT commented 1 month ago

@yidongnan Who is currently maintaining this project?