search

grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.
https://grpc-ecosystem.github.io/grpc-spring/
Apache License 2.0
3.54k stars 830 forks source link

Add support for server reflection v1 #1137

Open profhenry opened 3 months ago

profhenry commented 3 months ago

io.grpc 1.66.0 added support for server reflection v1, see https://github.com/grpc/grpc-java/issues/6724. io.grpc now comes with

When using grpc-spring with io.grpc >= 1.66.0 server reflection is still offered in version v1alpha, which works except for https://github.com/grpc-ecosystem/grpc-spring/issues/1136

It would be nice if grpc-spring could also offer server reflection v1 (in addtition to v1alpha for backward compatible). Maybe you could add a switch for choosing if v1 and/or v1alpha should be offered for server reflection.

Using server reflection v1 is easy, i tested replacing ProtoReflectionService by ProtoReflectionServiceV1 in https://github.com/grpc-ecosystem/grpc-spring/blob/a18aeeb25e60114ea773a621bfdc44902513ed07/grpc-server-spring-boot-starter/src/main/java/net/devh/boot/grpc/server/autoconfigure/GrpcReflectionServiceAutoConfiguration.java#L48 This works fine and even basic authentication works properly.

profhenry commented 3 months ago

Srs, this is a new feature and not a bug.