ST-DDT
commented
4 years ago I assume you are referring to this library? https://github.com/apache/skywalking
I don't have time to get into the details of that library right now. Is skywalking an alternative to Sleuth/OpenCensus/Zipkin or an alternative to micrometer metrics?
I assume all we have to do to support it is adding an optional dependency to this library: https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin And automatically add beans for these interceptors: https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/server/ServerInterceptor.java#L33 https://github.com/apache/skywalking/blob/master/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/client/ClientInterceptor.java#L26
As for the demo, I don't have time to write it myself. So it has to be provided by someone else who is willing to maintain it. Also it shouldn't be too large/complex. If them size is roughly the same as the cloud example, I'm willing to review it and then decide whether it adds enough value to this project to justify adding it. However, it is also possible that we decide that it has too little to do with the function of our library and should therefore better remain as a standalone/external demo. @yidongnan What do you think?
希望有skywalking链路追踪的集成demo, 有计划去支持这个吗?