Don't try to create grpcTracing bean if sleuth is not active

grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.

https://grpc-ecosystem.github.io/grpc-spring/

Apache License 2.0

3.52k stars 826 forks source link

Don't try to create grpcTracing bean if sleuth is not active #877

Closed genuss closed 1 year ago

genuss commented 1 year ago

Hello again! I found this inconsistency when trying to use this starter with spring boot 3. With 3.0 version there are cases when brave.Tracing is on classpath, although no bean is created. That's default behaviour in tests for example. There may be (mostly theoretically) such cases with spring boot 2.x too. I didn't create any tests, as this bug only shows up with 3.x branch.

ST-DDT commented 1 year ago

I don't have a real testing setup for this, so I have to just go by the code.

amitbansal26 commented 1 year ago

any updates on this ?