feat: Allow annotation GrpcClient for target type 'annotation'

grpc-ecosystem / grpc-spring

Spring Boot starter module for gRPC framework.

https://grpc-ecosystem.github.io/grpc-spring/

Apache License 2.0

3.46k stars 811 forks source link

Closed 313hemant313 closed 9 months ago

313hemant313 commented 9 months ago

Allow annotation GrpcClient for target type 'annotation'. #991

313hemant313 commented 9 months ago

@ST-DDT Test case added, please review.

ST-DDT commented 9 months ago

CI is red.

313hemant313 commented 9 months ago

Updated after ./gradlew :tests:spotlessApply. please run the job.

ST-DDT commented 9 months ago

Please pull and run the ./gradlew spotlessApply command again.

313hemant313 commented 9 months ago

./gradlew check and spotlessApply are success now.

313hemant313 commented 9 months ago

I was using java 19 version. changed it to 17 and pushed a new change with ./gradlew :tests:spotlessApply

313hemant313 commented 9 months ago

FFR: I find PRs easier to review if they aren't force pushed in between. Okay.

How to get this merged ?

ST-DDT commented 9 months ago

How to get this merged ?

You cannot merge this. We will have another reviewer look at this and then merge it.

313hemant313 commented 9 months ago

@ST-DDT / @yidongnan When will this change be in new maven release ?