search

grpc-requests / grpc_requests

python grpc reflection client
https://pypi.org/project/grpc-requests/
Apache License 2.0
33 stars 5 forks source link

Requirements are stricter than they need to be #50

Closed artificial-aidan closed 11 months ago

artificial-aidan commented 11 months ago

In requirements.txt grpcio and grpcio-reflection are pinned to >=0.1.53, but the code has support for older versions. I think it would make sense to set the requirements.txt to a less strict version. I think its probably the protobuf version that actually matters, so something like:

protobuf<4
grpcio
grpcio-reflection
ViridianForge commented 11 months ago

Probably fair calls - worth opening a PR and giving it a test.

ViridianForge commented 11 months ago

Requirements loosened up! Thanks for calling this out @artificial-aidan!