grpc / grpc-dart

The Dart language implementation of gRPC.
https://pub.dev/packages/grpc
Apache License 2.0
860 stars 271 forks source link

proto3 'optional' keyword support #507

Closed zs-dima closed 3 years ago

zs-dima commented 3 years ago

Currently optional Timestamp and optional Duration generate non-nullable types. However proto3 'optional' keyword means nullable types.

Could be nice to fix this issue to be able to have nullable and non-nullable proto3 types processed correctly.

related issues: https://github.com/protocolbuffers/protobuf/issues/2168 https://github.com/protocolbuffers/protobuf/issues/8822 https://github.com/grpc/grpc-dart/issues/502

Thanks in advance

mraleph commented 3 years ago

Closing in favor of https://github.com/google/protobuf.dart/issues/523