grpc / grpc-dart

The Dart language implementation of gRPC.
https://pub.dev/packages/grpc
Apache License 2.0
861 stars 271 forks source link

Bump http version from 0.13.0 to 1.0.0 #629

Closed ghatdev closed 1 year ago

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

domesticmouse commented 1 year ago

@kevmoo is Dart 2.17.0 intentional, or should the CI be moved to Dart stable and Dart beta.

kevmoo commented 1 year ago

@domesticmouse – we should have CI set to the oldest supported SDK

kevmoo commented 1 year ago

We should have a WIDE constraint on pkg:http – there were no breaks AFAIK

ghatdev commented 1 year ago

@kevmoo Is this will be O.K?

domesticmouse commented 1 year ago

@kevmoo Is this will be O.K?

Please update the CHANGELOG.md file to mention this change. You can use NEXT as the version that will include the change.

domesticmouse commented 1 year ago

Oh wait, it looks like the CI on this repo is set to publish on commit, and really doesn't like the version NEXT in the change log.

@kevmoo any preference on what the new version should be?

kevmoo commented 1 year ago

3.2.1 is great!

ghatdev commented 1 year ago

@kevmoo @domesticmouse I just set the version to 3.2.1

domesticmouse commented 1 year ago

@kevmoo any idea how to get this published?

kevmoo commented 1 year ago

I have the keys!

mraleph commented 1 year ago

@kevmoo you forgot to create a release... also there is a publishing workflow through actions (https://github.com/grpc/grpc-dart/blob/master/.github/workflows/publish.yaml) so you don't need to manually publish.

kevmoo commented 1 year ago

I don't have admin access to this repo – so the publish action was broken for me.