grpc / grpc-dart

The Dart language implementation of gRPC.
https://pub.dev/packages/grpc
Apache License 2.0
861 stars 271 forks source link

MaxMessageLength #659

Open farhodyusupov opened 1 year ago

farhodyusupov commented 1 year ago
Is there any way to set up MaxMessageLength?
mosuem commented 1 year ago

No, but please feel free to file a PR to implement this in ChannelOptions.

farhodyusupov commented 1 year ago

can you suggest something to start with?

mosuem commented 1 year ago

@jtattermusch I couldn't find any specs for this feature. Do specs for this exist, or is there a reference implementation?

mraleph commented 1 year ago

@mosuem I think this is about configuring CodedBufferReader's sizeLimit.

jtattermusch commented 1 year ago

@jtattermusch I couldn't find any specs for this feature. Do specs for this exist, or is there a reference implementation?

This is what's done for C-core: https://github.com/grpc/grpc/blob/12c97481349d88852490a4acd0b5a0f9301d5b6c/include/grpc/impl/channel_arg_names.h#L37 https://github.com/grpc/grpc/blob/12c97481349d88852490a4acd0b5a0f9301d5b6c/include/grpc/impl/channel_arg_names.h#L43

grpc-java would have something similar.

farhodyusupov commented 1 year ago

thank you, If I could succeed I will send pull request

farhodyusupov commented 1 year ago

@mosuem I think this is about configuring CodedBufferReader's sizeLimit.

I didn`t work