grpc / grpc-dart

The Dart language implementation of gRPC.
https://pub.dev/packages/grpc
Apache License 2.0
835 stars 256 forks source link

Make protobuf generated imports absolute #696

Closed mosuem closed 2 months ago

mosuem commented 2 months ago

To make replacing imports easier on importing into google3.

Disable test for now, see https://github.com/grpc/grpc-dart/issues/697

github-actions[bot] commented 2 months ago

PR Health

Breaking changes :heavy_check_mark:

Details | Package | Change | Current Version | New Version | Needed Version | Looking good? | | :--- | :--- | ---: | ---: | ---: | ---: | |grpc|None|3.2.4|3.2.4|3.2.4|:heavy_check_mark:|

Changelog Entry :exclamation:

Details | Package | Changed Files | | :--- | :--- | | package:grpc | lib/grpc.dart
lib/src/shared/status.dart | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs. This check can be disabled by tagging the PR with `skip-changelog-check`.

Coverage :warning:

Details | File | Coverage | | :--- | :--- | |lib/grpc.dart| :broken_heart: Not covered | |lib/src/shared/status.dart| :green_heart: 65 % | This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test-Coverage) is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with `skip-coverage-check`.

API leaks :warning:

Details The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API. | Package | Leaked API symbols | | :--- | :--- | |grpc|$1.Duration
ServerHandler
Any| This check can be disabled by tagging the PR with `skip-leaking-check`.

Package publish validation :heavy_check_mark:

Details | Package | Version | Status | | :--- | ---: | :--- | | package:grpc | 3.2.4 | already published at pub.dev | Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.