grpc / grpc-docker-library

Contains dockerfiles for gRPC in different languages
Apache License 2.0
207 stars 83 forks source link

Add 1.0 Docker images, and upgrade all the images to follow the Quick Starts for each language. #37

Closed markmandel closed 8 years ago

markmandel commented 8 years ago

I updated the language version for each one as well to what is latest.

I was tempted to remove the onbuild images - simply because they expanded the support required, but I updated the version numbers they depended on and left them in. Let me know your thoughts.

Please let me know if there is any adjustment / refinement you would like to see.

markmandel commented 8 years ago

Updated the Dockerfiles so that they all have linebreaks, and fixed up all the readme's in the 1.0 folder such that they state "gRPC" (worth nothing that in 0.10 and 0.11 folders, they are still "grpc")

Please let me know if you have any further feedback.

nathanielmanistaatgoogle commented 8 years ago

I was just jumping on some cosmetic stuff; @nicolasnoble will be the reviewer of substance for this change (or he will route this change to someone else who will be).

markmandel commented 8 years ago

No worries. Good catches. Fixed up now. :+1:

markmandel commented 8 years ago

Added newline. Let me know if you would like a rebase to clean up the commit history or not :smiley:

nathanielmanistaatgoogle commented 8 years ago

I favor this squashing; @nicolasnoble will be the one to actually decide.

markmandel commented 8 years ago

@nicolasnoble What do you reckon? Shall I squash it, and then it can be merged? :smile:

nicolasnoble commented 8 years ago

I don't really care either way - that repository has less importance when it comes to history, so squash, don't squash, do what you prefer :)

markmandel commented 8 years ago

@nathanielmanistaatgoogle Do you feel strongly either way? I don't mind. I just want to get this through the door? :smile:

nathanielmanistaatgoogle commented 8 years ago

Squash.

nathanielmanistaatgoogle commented 8 years ago

Also for extra bonus points adhere to these guidelines.

markmandel commented 8 years ago

@nathanielmanistaatgoogle Squashed and updated the commit message.

(Love that guideline. Stealing for future use)

markmandel commented 8 years ago

Thank you!