grpc / grpc-docker-library

Contains dockerfiles for gRPC in different languages
Apache License 2.0
207 stars 83 forks source link

upgrade to protoc v3.1.0 #38

Closed andrewrothstein closed 7 years ago

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


andrewrothstein commented 7 years ago

I signed it

MaerF0x0 commented 7 years ago

@murgatroid99 Any chance you can help this along? I'd like to submit a PR for 3.2 as well.

markmandel commented 7 years ago

LGTM - @nathanielmanistaatgoogle @nicolasnoble can we merge?

nathanielmanistaatgoogle commented 7 years ago

Maybe. I'm not even sure who's in charge of this repository these days; it could be @nicolasnoble or it could be someone else.

MaerF0x0 commented 7 years ago

@nathanielmanistaatgoogle , @nicolasnoble , @markmandel Do any of you either 1) know who is responsible for this repo or 2) Can find out who is?

I'd like to do some work on it (particularly updating protoc and golang versions), but dont want to waste my time if it wont get merged.

nathanielmanistaatgoogle commented 7 years ago

@dfawley: please review and merge this Go change?

@nicolasnoble, @hsaliak: what's up with this repository? If we don't want to own it, should we delete it? If we do want to own it, should we be better about integrating pull requests?