grpc / grpc-docker-library

Contains dockerfiles for gRPC in different languages
Apache License 2.0
207 stars 83 forks source link

Add gRPC 1.4 and Python 3.6 support #46

Closed davidgasquez closed 7 years ago

davidgasquez commented 7 years ago

This PR is related to https://github.com/grpc/grpc-docker-library/issues/45. The new 1.4 folder contains a Dockerfile that implements gRPC 1.4 for Python 3.6.

Happy to change anything! Let me know your thoughts and feedback 😄

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


davidgasquez commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

nathanielmanistaatgoogle commented 7 years ago

Please squash commits and conform to these commit message guidelines.

I'd forgotten this repository existed! What brings you here? Thanks for the improvement!

davidgasquez commented 7 years ago

Commits squashed @nathanielmanistaatgoogle! Let me know if I should do anything else :)

We've started to use gRPC and instead of building our own base image I decided to contribute here. 😄

nathanielmanistaatgoogle commented 7 years ago

Whoops; something else I forgot: we recently relicensed, so I don't think it's appropriate to copy the license headers off the extant files in this repository. See this file for the license header that (I believe) should be used for new files.

davidgasquez commented 7 years ago

Thanks for the information @nathanielmanistaatgoogle! 😄 I updated the License on both Dockerfiles.

nathanielmanistaatgoogle commented 7 years ago

Thanks!

davidgasquez commented 7 years ago

Sorry @nathanielmanistaatgoogle, do you know if the new images will be available in https://hub.docker.com/r/grpc/python/builds/?

markmandel commented 7 years ago

I can set that up - at an event at the moment, but will jump on it today/tomorrow. Feel free to harass me if need be. 👍

markmandel commented 7 years ago

New images are now live!

davidgasquez commented 7 years ago

Thanks for setting that up @markmandel! Also, thanks again @nathanielmanistaatgoogle for the help. 😄