grpc / grpc-docker-library

Contains dockerfiles for gRPC in different languages
Apache License 2.0
207 stars 83 forks source link

Protobuf include directory #47

Closed abice closed 7 years ago

abice commented 7 years ago

The current build only copies the protoc/bin/protoc binary from the protobuf release. This doesn't allow for any protoc compilation that requires the standard google.protobuf includes. Changed the copy function to copy everything to /usr/local which includes the bin directory and the include directory.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


abice commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

nathanielmanistaatgoogle commented 7 years ago

Two commits to change one line? Huh? Just squash commits (and conform to these guidelines with your commit message).

dfawley commented 7 years ago

Thanks for the fix!