search

grpc / grpc-docker-library

Contains dockerfiles for gRPC in different languages
Apache License 2.0
207 stars 83 forks source link

Fix Bug: Need a limit on the -j parellisation #51

Closed markmandel closed 6 years ago

markmandel commented 6 years ago

An unbounded -j can cause all kind of errors and will fail to compile on Dockerhub.

$(nproc) limits parallelisation to the number of cores on the machine, and this has been tested on Dockerhub.

https://hub.docker.com/r/markmandel/grpc-docker-library/builds/

markmandel commented 6 years ago

@mehrdada PR to fix the bug for you - you were 100% correct :blush:

markmandel commented 6 years ago

Build successful! - https://hub.docker.com/r/grpc/cxx/builds/bk7g8cjekdrs3qp8w4urpjf/