grpc / grpc-docker-library

Contains dockerfiles for gRPC in different languages
Apache License 2.0
207 stars 83 forks source link

Fix release versions of 'protoc-gen-go' and 'google.golang.org/grpc' #57

Closed walesey closed 6 years ago

walesey commented 6 years ago

My team and I are currently using your grpc/go:1.0 docker image to generate go code from our proto files.

We found an issue where you had published multiple versions of the 1.0 tag that each had a different versions of protoc-gen-go. This meant that different members on my team were generating slightly different code from the same proto file. (each person had a different version of 1.0 in their local docker cache).

I've provided a fix for the Dockerimage that installs the protoc-gen-go/grpc dependencies from stable release builds instead.

thelinuxfoundation commented 6 years ago

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards, CLA GitHub bot

srini100 commented 6 years ago

@walesey, please sign CLA.

walesey commented 6 years ago

testing CLA

dfawley commented 6 years ago

@walesey,

This is the 1.0/golang/Dockerfile but with your change, it fetches 1.13. It was fetching HEAD before, so technically this may be an improvement in some regard, but it's still misleading.

We would prefer not to maintain dockerfiles for Go in this repo any longer. The complexity of getting a grpc-go environment up and running does not justify it in our opinion. However, I'm not sure what problems we might cause if we just deleted this directory completely, either. As a user, do you have any input on this? Thanks!

walesey commented 6 years ago

Currently we find docker useful as a means of generating consistent go code from proto files. We just need to make sure the dependencies are locked down.

I've changed the grpc version to 1.0.