search

grpc / grpc-docker-library

Contains dockerfiles for gRPC in different languages
Apache License 2.0
207 stars 83 forks source link

Android Dockerfile #6

Closed madongfly closed 9 years ago

madongfly commented 9 years ago
madongfly commented 9 years ago

@ejona86 @donnadionne @zsurocking

ejona86 commented 9 years ago

@madongfly LGTM. I still have an outstanding question, but it looks good.

ejona86 commented 9 years ago

That all makes sense. Still LGTM

ejona86 commented 9 years ago

@madongfly, you merged this? Should we remove it from grpc-docker-library now that we have it in grpc?

madongfly commented 9 years ago

@ejona86, seems this repo was ported from grpc, so there should be a reason, like providing better reference?

Anyway, I don't mind deleting the android docker file, but I can't think of a reason of only remove the android docker file while keep the others.

ejona86 commented 9 years ago

This repo is intended for users of grpc, in order to have a working environment. The stuff in grpc is for our usage and testing.