search

grpc / grpc-docker-library

Contains dockerfiles for gRPC in different languages
Apache License 2.0
207 stars 83 forks source link

Added docker image for grpc cxx v1.28.0 #73

Closed AntoineRondelet closed 4 years ago

AntoineRondelet commented 4 years ago

Added dockerfile to build the docker image corresponding to the latest release of grpc for cpp

linux-foundation-easycla[bot] commented 4 years ago

CLA Check
One or more committers are not authorized under a signed CLA as indicated below. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

AntoineRondelet commented 4 years ago

@jtattermusch (I am tagging you as I saw you as a owner here: https://github.com/grpc/grpc/blob/master/tools/dockerfile/OWNERS) I can see that this repo is not maintained anymore. Do you have plans to track a branch (I guess master on the gRPC repo https://github.com/grpc/grpc) in order to automate the building and deployment of docker images for each release? It'd be great to have up to date grpc images to use as base images for other projects.

Maybe this is already done and I am missing something, but by looking at the docker hub: https://hub.docker.com/r/grpc/cxx/tags the latest images are pretty old.. (2 years old - and from what I see, the image building grpc v1.21.0 wasn't pushed to the docker hub)

And as a side question: I there a reason why you used debian as base image, and not, alpine? Alpine is much lighter (even though one may argue that after compiling grpc as part of the image built, having an image a few MB lighter doesn't really matter haha)

jtattermusch commented 4 years ago

Thanks for the PR, but as noted here: https://github.com/grpc/grpc-docker-library/blob/master/README.md this repository is deprecated and there's not point in adding new images.

The dockerfiles under https://github.com/grpc/grpc/blob/master/tools/dockerfile/ are for internal testing purposes only - right now we unfortunately don't provide official docker images for grpc.