grpc / grpc-experiments

Experiments and proposals for gRPC features.
1.07k stars 182 forks source link

Move examples to grpc-* repos #282

Closed stanley-cheung closed 9 years ago

philips commented 9 years ago

When will this be rebuilt on grpc.io? There are problems with the grpc.io Go examples: http://www.grpc.io/docs/installation/go.html

LisaFC commented 9 years ago

We're actually moving all the quickstart/installation guides out of grpc.io in the next major update, and just linking to the relevant READMEs in the relevant depot, as they are probably most useful next to the code. Grpc.io will have more substantial guides, tutorials and reference material.

In the meantime, if this is correct (https://github.com/grpc/grpc-go/tree/master/examples) and the version on grpc.io isn't, I can just make the update myself now if you like?

philips commented 9 years ago

@LisaFC These are the fixes that the grpc.io page needs.

LisaFC commented 9 years ago

Ah, I see, the link to the helloworld.proto is broken (in fairness, it's also broken in the repo README). The repo README also tells users to get the code using

go get -u google.golang.org/grpc/examples/helloworld/greeter_client

while the grpc.io page says

go get -u github.com/grpc/grpc-go/examples/helloworld/greeter_client

philips commented 9 years ago

@LisaFC Yes, the grpc-go repo one is correct.

LisaFC commented 9 years ago

Done!