search

grpc / grpc-go

The Go language implementation of gRPC. HTTP/2 based RPC
https://grpc.io
Apache License 2.0
20.72k stars 4.32k forks source link

internal/credentials/xds: add unit test for HandshakeInfo.Equal #6568

Open easwars opened 1 year ago

easwars commented 1 year ago

We made the Equal method actual perform a deep equal instead of pointer equality. We should add tests for it. https://github.com/grpc/grpc-go/blob/master/internal/credentials/xds/handshake_info.go#L47

Aditya-Sood commented 9 months ago

hi @ginayeh, can I pick this up?

dfawley commented 9 months ago

Let us know if you still want this @Aditya-Sood - I already assigned a few other things to you and don't want to overwhelm.

Aditya-Sood commented 9 months ago

hi @dfawley, yes I've responded to the action items for me on the open PRs I will start working on #6763, can pick this up after that?

miledxz commented 6 months ago

@arvindbr8 I would love to take this one, if you think it's fine feel free to assign me

arvindbr8 commented 6 months ago

@zedGGs -- Thanks for your interest. But it seems like we have a PR in flight. I'm more than happy to reserve this to you until we have merged that one in.

miledxz commented 1 month ago

@arvindbr8 feel free to assign me on this since we finalised ongoing pr already