search

grpc / grpc-go

The Go language implementation of gRPC. HTTP/2 based RPC
https://grpc.io
Apache License 2.0
20.95k stars 4.35k forks source link

Experimental API related to metadata #7298

Closed KarthikReddyPuli closed 3 months ago

KarthikReddyPuli commented 4 months ago

I would like to fetch metadata in a more efficient manner and I found an API that is experimental but the PR was ~2 years ago. Can I consider this safe to use now ? Is there any plan on removing the experimental tag on this API and make it permanent ?

PR for reference: https://github.com/grpc/grpc-go/pull/5596

arjan-bal commented 3 months ago

Hi @KarthikReddyPuli, we would like to get feedback before stabilising an experimental API. This helps avoid the risk of needing breaking changes after stabilisation. If users are happy with an experimental API and request it's stabilisation, we will stabilise it.

You can use the ViewFromIncomingContext function and share feedback, if any. The gRPC project still reserves the right to make breaking changes to it, however we don't have any changes planned currently, and don't foresee any in the near future

github-actions[bot] commented 3 months ago

This issue is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

KarthikReddyPuli commented 3 months ago

Hi @arjan-bal, thanks for the reply. We have started using this API and we have found considerable improvements in our profiler. I request to stabilise this API in any of the upcoming releases. TIA

arjan-bal commented 3 months ago

Good to know that the API works well.

Assigning to @dfawley to comment on stabilisation of the API.

dfawley commented 3 months ago

I don't have any objections.

KarthikReddyPuli commented 3 months ago

@arjan-bal I have raised a PR to stabilise this API, can you please help in review/merging it ? https://github.com/grpc/grpc-go/pull/7368