search

grpc / grpc-go

The Go language implementation of gRPC. HTTP/2 based RPC
https://grpc.io
Apache License 2.0
20.88k stars 4.34k forks source link

metadata: MD.String should only show metadata known to not contain tokens or other PII #7395

Open dfawley opened 2 months ago

dfawley commented 2 months ago

Unfortunately, we know this change will break etcd, so it should not be done yet. (See: https://github.com/etcd-io/etcd/blob/21e5876f7f0539509c277b4c2a3ba1b1599b1721/client/v3/watch.go#L1038-L1043.) I will file an issue in the etcd repo and link it here.

dfawley commented 2 months ago

Update: the changes have been made to etcd to stop relying on this, and have been backported to release branches, but we still need to wait for their releases before implementing anything.