search

grpc / grpc-go

The Go language implementation of gRPC. HTTP/2 based RPC
https://grpc.io
Apache License 2.0
21.08k stars 4.38k forks source link

Flaky test: Test/ProducerStreamStartsAfterReady #7648

Closed zasweq closed 1 month ago

zasweq commented 1 month ago

https://github.com/grpc/grpc-go/actions/runs/10932308386/job/30348934900

zasweq commented 1 month ago

@dfawley it seems like the test this was supposed to fix also continues to flake #7507 :/. The error message seems to imply that a stream continues to start after a before a ready listener returned "producer_ext_test.go:83: Producer stream started before Ready listener returned", so perhaps the root cause of this race wasn't fully fixed and there's some more code paths that can induce this race?

Probably a little more important now that we're going to use this producer stream for generic health checking as well once the DualStack changes are merged.

dfawley commented 1 month ago

Excellent! We had seen the other test flake but this is proof that the root cause can probably still be attributed to this issue. I'll take a look and see if I can figure out ways things could get ordered incorrectly.

easwars commented 1 month ago

https://github.com/grpc/grpc-go/actions/runs/10935353416/job/30356957364?pr=7567