search

grpc / grpc-ios

gRPC for iOS
Apache License 2.0
37 stars 22 forks source link

Fix build and add CI #218

Closed paulb777 closed 8 months ago

paulb777 commented 8 months ago

Fix SPM build issues and add CI for future regression testing

Screenshot 2023-10-23 at 4 07 59 PM

paulb777 commented 8 months ago

@sampajano Would appreciate your team's review, merge, and 1.49.2 tag to fix the SPM build issues. And also to carry the fixes and CI forward to future releases.

cc: @ncooke3 @wu-hui

sampajano commented 8 months ago

@paulb777 Thanks for filing the issue!

I suppose this was the same one we've been discussion? i.e. regarding use_frameworks?

paulb777 commented 8 months ago

@sampajano No, this is different. use_frameworks! is a CocoaPods issue. This PR fixes the Swift Package Manager build and adds CI to help keep it working.

sampajano commented 8 months ago

@paulb777 Oh! Sorry i didn't look closely!

Thanks so much for adding the CI for us!!

This looks great!

@HannahShiSFB PTAL too!