CFStream Test Suite Bazel Migration - Githubissues

grpc / grpc-ios

gRPC for iOS

Apache License 2.0

39 stars 22 forks source link

CFStream Test Suite Bazel Migration #48

Open dennycd opened 2 years ago

dennycd commented 2 years ago

Our CFStream test suite currently have a few issues that need to be improved

Test hangs and keep retries until timeout if test failure
Async test logic is using NSRunLoop mainRunLoop instead of XCTestExpectation

In addition, the current test suite is an objc translation from existing c-core test

https://github.com/grpc/grpc/blob/master/test/core/iomgr/BUILD#L241

We should revisit the test setup to run c-core's test setup using the corresponding ios unit test target instead

https://github.com/grpc/grpc/blob/master/bazel/grpc_build_system.bzl#L335

Additional todos for CFStream Test Update

Migrate CFStream test to bazel based
Move CFStream test out of test/core/iomgr and move into src/objective-c so that it is co-located with the rest of the ios/objc test.

jtattermusch commented 1 year ago

Note the the ios-test-cfstream-tests test suite is last one in the grpc_basictests_objc_ios job. After it gets migrated to bazel, we can basically get rid of the grpc_basictests_objc_ios job.