inprocess: Support tracing message sizes guarded by flag

[shivaspeaks]

We shouldn't do this every message.

What does that mean? You mean we should move it to somewhere else? Perhaps to a place where constants are defined?

On Tue, 22 Oct 2024 at 8:19 PM, Eric Anderson @.***> wrote:

@.**** commented on this pull request.

In inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java https://github.com/grpc/grpc-java/pull/11629#discussion_r1810881054:

@@ -358,6 +358,13 @@ private static int metadataSize(Metadata metadata) { return (int) size; }

• /**
• • Returns true if env var is set.
• */
• static boolean isEnabledSupportTracingMessageSizes() {
• return GrpcUtil.getFlag("GRPC_EXPERIMENTAL_SUPPORT_TRACING_MESSAGE_SIZES", false);

We shouldn't do this every message.

— Reply to this email directly, view it on GitHub https://github.com/grpc/grpc-java/pull/11629#pullrequestreview-2385455970, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANRG3B6XM6IKQYRKNTFRBRTZ4ZQWXAVCNFSM6AAAAABQMLV5L6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBVGQ2TKOJXGA . You are receiving this because you authored the thread.Message ID: @.***>

[ejona86]

You mean we should move it to somewhere else? Perhaps to a place where constants are defined?

Add it as a field to the transport.