search

grpc / grpc-java

The Java gRPC implementation. HTTP/2 based RPC
https://grpc.io/docs/languages/java/
Apache License 2.0
11.44k stars 3.85k forks source link

NettyFlowControlTest is flaky #2297

Open lukaszx0 opened 8 years ago

lukaszx0 commented 8 years ago

Happened few times for me, in CI as well as locally:

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:171)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:141)
ejona86 commented 8 years ago

How often is this happening? I assume you've just been noticing it on your hardware?

lukaszx0 commented 8 years ago

Nope, it happened in CI too (sorry, don't have link handy). Can't tell how often, but last time I was contributing something, I got beaten by it 3-4 times during development (so both local and remote CI)

ejona86 commented 8 years ago

What I tend to encourage is that each time you see it, put a comment here (with a link if you have one). That way we can see how much pain it is causing, or whether it just happened once to one person.

lukaszx0 commented 8 years ago

Yeah, my bad. Sorry, will do!

On Thu, Oct 20, 2016 at 2:52 PM, Eric Anderson notifications@github.com wrote:

What I tend to encourage is that each time you see it, put a comment here (with a link if you have one). That way we can see how much pain it is causing, or whether it just happened once to one person.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/grpc/grpc-java/issues/2297#issuecomment-255238735, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAtKqe0zzES0ADnOaY_nnZK8M7v8VWBks5q1-KagaJpZM4KE_1h .

Łukasz

lukaszx0 commented 8 years ago

Just happened to me locally:

objc[44415]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
[jetty-alpn-agent] Using: alpn-boot-8.1.8.v20160420.jar

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:172)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:142)

242 tests completed, 1 failed
:grpc-interop-testing:test FAILED

FAILURE: Build failed with an exception.
ejona86 commented 7 years ago

Failed with https://travis-ci.org/grpc/grpc-java/jobs/176197614 (since rebuilt)

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 688278 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:172)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:142)
lukaszx0 commented 7 years ago

Failed locally:

:grpc-interop-testing:test
objc[83215]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/bin/java (0x10dad54c0) and /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/jre/lib/libinstrument.dylib (0x10db9d4e0). One of the two will be used. Which one is undefined.
[jetty-alpn-agent] Using: alpn-boot-8.1.8.v20160420.jar

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:172)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:142)

246 tests completed, 1 failed
ejona86 commented 7 years ago

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/2740/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655360 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:172)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:142)
ejona86 commented 7 years ago

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/2859/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 816980 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:169)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:139)
ejona86 commented 7 years ago

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/2909/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:169)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:139)
ejona86 commented 7 years ago

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/2968/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 655492 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:169)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:139)
lukaszx0 commented 7 years ago

Nowadays, I'm hitting it pretty much every time I'm working on PR. Is is still worth posting failed builds here?

ericgribkoff commented 7 years ago

Failed at https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/3316/console

io.grpc.testing.integration.NettyFlowControlTest > verySmallWindowMakesProgress FAILED
    java.lang.AssertionError: Window was 687918 expecting 314570
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:169)
        at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:139)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/46/

java.lang.AssertionError: Window was 687918 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/50/

java.lang.AssertionError: Window was 655360 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/54/

java.lang.AssertionError: Window was 687918 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ericgribkoff commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/157/

java.lang.AssertionError: Window was 720686 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)    
        at org.junit.Assert.assertTrue(Assert.java:41)  
        at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154) 
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/63/

java.lang.AssertionError: Window was 687918 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124
ericgribkoff commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/204/

java.lang.AssertionError: Window was 655360 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/78/

java.lang.AssertionError: Window was 687918 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/104/

java.lang.AssertionError: Window was 687918 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/105/

java.lang.AssertionError: Window was 687918 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/307/

java.lang.AssertionError: Window was 687918 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/310/

java.lang.AssertionError: Window was 753454 expecting 314570
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at io.grpc.testing.integration.NettyFlowControlTest.doTest(NettyFlowControlTest.java:154)
    at io.grpc.testing.integration.NettyFlowControlTest.verySmallWindowMakesProgress(NettyFlowControlTest.java:124)
ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/111/

ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/112/

ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/115/ (from Aug 31)

ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/132/

ejona86 commented 7 years ago

https://grpc-testing.appspot.com/job/gRPC-Java-PR-Windows/4246/console

ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/134/

ericgribkoff commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/507/

ejona86 commented 7 years ago

https://kokoro.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/158/ (From Sept 29th)

ejona86 commented 7 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/55/

ejona86 commented 7 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/21/

zpencer commented 7 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/188/

ejona86 commented 7 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/45/

ejona86 commented 7 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/48/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/277/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/continuous/job/windows/104/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/515/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/540/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/job/presubmit/job/windows/705/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/presubmit/job/windows/68/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/21/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/presubmit/job/windows/92/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/29/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/43/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/presubmit/job/windows/221/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/presubmit/job/windows/289/

ejona86 commented 6 years ago

https://kokoro2.corp.google.com/job/grpc/job/java/job/master/job/windows/75/