search

grpc / grpc-java

The Java gRPC implementation. HTTP/2 based RPC
https://grpc.io/docs/languages/java/
Apache License 2.0
11.4k stars 3.83k forks source link

update reflection.proto from v1alpha to v1 #6724

Open thesamet opened 4 years ago

thesamet commented 4 years ago

What version of gRPC-Java are you using?

1.27.1

What is your environment?

SBT

What did you expect to see?

grpc-services contains deprecated v1alpha/reflection.proto which instructs to use v1/reflection.proto, however the file is not shipped with this jar. It is unclear if there's a maven artifact that contains it that should be used instead.

ericgribkoff commented 4 years ago

There is no maven artifact that should be used instead. The proto was marked as "deprecated" in https://github.com/grpc/grpc-java/pull/4973, but AFAICT there has been no effort since then to move any of the tooling around v1alpha/reflection.proto to the "canonical" v1/reflection.proto. Reflection in C++, Java, or Go is all still using the v1alpha API, along with tooling like grpc_cli.

Neither the gRPC core repo (https://github.com/grpc/grpc/blob/master/src/proto/grpc/reflection/v1alpha/reflection.proto) nor the gRPC Go repo (https://github.com/grpc/grpc-go/blob/master/reflection/grpc_reflection_v1alpha/reflection.proto) include the comment that the proto is "deprecated".

Is this causing you some kind of issue? It certainly looks like something we need to internally clean up, but I would be interested to hear if this has impacted end users.

thesamet commented 4 years ago

The only problem it causes is deprecation warnings, which I can suppress until this is cleaned up.

priyendra commented 4 years ago

"The only problem it causes is deprecation warnings, which I can supress ..."

Do you have a pointer on how deprecation warnings can be suppressed in Bazel?

thesamet commented 4 years ago

Do you have a pointer on how deprecation warnings can be suppressed in Bazel?

I currently don't use bazel, the comment was referring to a Scala build in SBT (using silencer to silence deprecation warnings)

lbroudoux commented 7 months ago

Hi,

Is there any news regarding the support of reflection v1 in Java grpc-services? The latest versions of tools like grpcurl now support this version (sending request with grpc.reflection.v1.ServerReflection/ServerReflectionInfo method name) and make the ProtoReflectionService useless on our server implementation.

The file in grpc-go is now marked as deprecated even if the one in grpc-core is not. 🤔