grpc / grpc-kotlin

Kotlin gRPC implementation. HTTP/2 based RPC
https://grpc.io/docs/languages/kotlin
Apache License 2.0
1.2k stars 163 forks source link

Insure Generated Code Passes Ktlint #162

Open jamesward opened 4 years ago

jamesward commented 4 years ago

See: https://github.com/GoogleCloudPlatform/kotlin-samples/issues/76

Kernald commented 3 years ago

Just my two cents: does it really matter? I'm not sure of the value of running linters on generated code. With that said, the only issue here seems to be the file name, so addressing it should be relatively straightforward.

jamesward commented 3 years ago

I think it depends on if the linter runs by default on the generated code. I need to see if it usually does or if it is just due to how the linter is used in that project.