search

grpc / grpc-swift

The Swift language implementation of gRPC.
Apache License 2.0
2.04k stars 420 forks source link

[nio] minor issue with project initialization #693

Closed Kirow closed 4 years ago

Kirow commented 4 years ago

New Issue Checklist

Issue Description

  1. Clone and make xcode project file:

    git clone -b nio https://github.com/grpc/grpc-swift.git
cd grpc-swift
make project

    Error - No such file or directory -- fix-project-settings.rb (LoadError). This command should be removed from Makefile or fix-project-settings.rb should be restored.

  2. Open project > Manage Scheme > add GRPC > build on iOS Error - Compiling for iOS 8.0, but module 'SwiftProtobuf' has a minimum deployment target of iOS 13.2. Manual change will helps of course, but it could be that there is a setting for this somewhere and it is possible to make it 8.0 during initialization.

Environment


| Key                           | Value                                                         |
| ----------------------------- | --------------------------------------------------------------|
| OS Version                    |  10.14.6                                                       |
| Swift Version                 |   5.1.3                                                       |
| Xcode Version                 |   11.3                                                       |
| gRPC-Swift Version            |  [nio](https://github.com/grpc/grpc-swift/commit/be70633c91d722496e5fcb225f822edbd5c36a5a)                                                      |
glbrntt commented 4 years ago

Thanks for filing this @Kirow.

With regards to the second, I think the appropriate fix here is adding platform availability the Package.swift. Just as an FYI, the minimum supported iOS version should be 10.0 (this the minimum version of iOS supported by SwiftNIO).

I'll file a couple of PRs to address these.

glbrntt commented 4 years ago

One other thing in case you didn't know, with Xcode 11 you don't need to generate an .xcodeproj (if you're only using SwiftPM). You can either open the grpc-swift directory from Xcode or you can run xed . from the grpc-swift directory.

Kirow commented 4 years ago

Yes, I tried Xcode11 SwiftPM and it worked well, but not so well in AppCode that I'm using. So I need to use git submodules or cocoapods while there is no good support in the IDE.

glbrntt commented 4 years ago

This should've been fixed by #695 -- please reopen if it isn't!