search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.56k stars 762 forks source link

node-client.js is redundant？ #1177

Closed alanhe421 closed 2 years ago

alanhe421 commented 2 years ago

https://github.com/grpc/grpc-web/blob/69a16b603359334884a04927572cc96de36f80bf/net/grpc/gateway/examples/helloworld/node-client.js#L26

  1. I found no usage about node-client.js.
  2. What is the purpose of this file and how to use it?

image

sampajano commented 2 years ago

Thanks for noticing :)

You're right it's not referred anywhere in the exmaples.

Although, maybe that was used to showcase how grpc-web can be used from a node runtime?

I'm not sure if it works anymore tho :)

jasonclg commented 2 years ago

I had the same question. Please consider adding some notes about node-client.js in README (or remove the file?). Thanks :)

sampajano commented 2 years ago

Checked with team, actually node-client.js is used to test against the node grpc server (without Envoy proxy) just in case things aren't working.. so it doesn't actually speak grpc-web! Will add note to clarify. Thanks for noticing and the suggestions! :)