Correctly support proto3 optional fields in commonjs+dts .d.ts output

grpc / grpc-web

gRPC for Web Clients

https://grpc.io

Apache License 2.0

8.56k stars 762 forks source link

Correctly support proto3 optional fields in commonjs+dts .d.ts output #1184

Closed mattnathan closed 2 years ago

mattnathan commented 2 years ago

Fixes #1072

linux-foundation-easycla[bot] commented 2 years ago

The committers are authorized under a signed CLA.

:white_check_mark: Matt Nathan (725997981fa97f865428bbcb33c24c911073c4b2)

mattnathan commented 2 years ago

I think this is correct, I'm not entirely sure how to build or test it. Guidance would be greatly appreciated.

mattnathan commented 2 years ago

I've managed to build (via bazel) and test this locally against some proto files I have with optional fields and it correctly outputs hasXxx and clearXxx methods for those fields in the .d.ts files.

mattnathan commented 2 years ago

Sorry for any delays in responses, UK based over here

sampajano commented 2 years ago

Sorry for any delays in responses, UK based over here

Np at all! That's almost no delay at all (compared it taking 16 days for me to review 😂)..

Thanks again for the contribution and being patient with the review! :)

(I will cut a release very soon (maybe today or latest next week) which contains this fix. Thanks! :))