search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.51k stars 766 forks source link

Fix JS Generator Identifier when name is camel case #1227

Closed nnnnoel closed 1 year ago

nnnnoel commented 2 years ago

This PR fixes JS Generator when field name is camel case protocolbuffers/protobuf-javascript#17

protobuf PR: https://github.com/protocolbuffers/protobuf-javascript/pull/3

example

message Message {
    int32 someCamelCaseMessage = 1;
}
linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

sampajano commented 2 years ago

Thank you so much for taking the initiative to fix this both in protobuf and here!

I'll probably take a look after the protobuf change is approved! :) Please ping the thread here once it is. Thanks! :)

nnnnoel commented 1 year ago

I don't know why protobuf PR has closed. but I also close this PR because of https://github.com/protocolbuffers/protobuf-javascript/pull/3

sampajano commented 1 year ago

Ahh not sure about protobuf.. Thanks for the update anyways tho..