make sure envoy is pid 1

grpc / grpc-web

gRPC for Web Clients

https://grpc.io

Apache License 2.0

8.51k stars 766 forks source link

make sure envoy is pid 1 #1246

Closed ericb-summit closed 2 years ago

ericb-summit commented 2 years ago

This ensures signals are handled properly so docker stop responds quickly and doesn't need to wait for time out (10s by default)

By default ENTRYPOINT passed as string (not an array) translates to /bin/sh -c followed by the value which means sh is pid 1, not envoy, and docker stop hangs for 10s.

linux-foundation-easycla[bot] commented 2 years ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: ericb-summit (a286b14b44ae77ec34f6cfe8b26efad5863d08ef)

sampajano commented 2 years ago

Nice trick! Thanks for the PR! Do you mind doing the EasyCLA process? thanks!

ericb-summit commented 2 years ago

Done