Fix duplicate dot in enum name (when "package" is specified) - Githubissues

grpc / grpc-web

gRPC for Web Clients

https://grpc.io

Apache License 2.0

8.6k stars 765 forks source link

Fix duplicate dot in enum name (when "package" is specified) #1286

Closed sampajano closed 2 years ago

sampajano commented 2 years ago

Summary

Fix a bug introduced in https://github.com/grpc/grpc-web/pull/1278 where an extra dot is inserted when "package" is specified in the enum being imported.

Changes

This fix makes StripPrefixString remove the leading dot when stripping out a prefix -- and hence will work in both cases (with and without package).
Also removed a few now redundant logic to remove leading dots.

Tested

With both example in #1271 and #1284

Fixes #1284